Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add finalizer to preventing HPA from being deleted before replicas synced #4084

Closed
wants to merge 1 commit into from
Closed

add finalizer to preventing HPA from being deleted before replicas synced #4084

wants to merge 1 commit into from

Conversation

lxtywypc
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
As #4072 (comment)
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 22, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garrybest after the PR has been reviewed.
You can assign the PR to them by writing /assign @garrybest in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 93.67% and project coverage change: +0.17% 🎉

Comparison is base (48b8e9f) 53.50% compared to head (5e6674a) 53.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
+ Coverage   53.50%   53.68%   +0.17%     
==========================================
  Files         234      234              
  Lines       23281    23345      +64     
==========================================
+ Hits        12457    12532      +75     
+ Misses      10143    10130      -13     
- Partials      681      683       +2
Flag Coverage Δ
unittests 53.68% <93.67%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pareplicassyncer/hpa_replicas_syncer_controller.go 79.71% <93.67%> (+35.11%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Oct 10, 2023
Closed
8 tasks
@XiShanYongYe-Chang
Copy link
Member

Hi @lxtywypc, we probably don't need this PR anymore, so let's close it.

Thanks again for your contribution.

/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closed this PR.

In response to this:

Hi @lxtywypc, we probably don't need this PR anymore, so let's close it.

Thanks again for your contribution.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pigletfly pigletfly Awaiting requested review from pigletfly

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lxtywypc @karmada-bot @codecov-commenter @XiShanYongYe-Chang